-
Notifications
You must be signed in to change notification settings - Fork 41
Update to ACK runtime v0.54.1, code-generator v0.54.0
#337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ack-bot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 days ago
To fix this issue, add a permissions block to the workflow file .github/workflows/postsubmit.yaml. The block should be placed at the root, above the jobs: key, making the permission settings apply to all jobs unless overridden by the reusable workflow or within specific jobs. As the optimal least-privilege configuration depends on what the invoked workflow and jobs do, a safe starting point is contents: read, which is the most restrictive and recommended by GitHub for workflows that do not require write access; you can add other entries (like pull-requests: write) only if required. Since the shown code doesn't indicate any write operations, using only contents: read is appropriate.
Edit the file .github/workflows/postsubmit.yaml to add:
permissions:
contents: readThis should be inserted after the name: and before the on: line.
No other methods, imports, or changes are required for this fix.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
|
/retest |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update to ACK runtime
v0.54.1, code-generatorv0.54.0v0.54.0release notesv0.54.1release notesNOTE:
This PR increments the release version of service controller from
v1.5.1tov1.5.2Once this PR is merged, release
v1.5.2will be automatically created forsagemaker-controllerPlease close this PR, if you do not want the new patch release for
sagemaker-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.